Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use docker compose healthcheck #944

Merged
merged 1 commit into from Jun 16, 2023
Merged

use docker compose healthcheck #944

merged 1 commit into from Jun 16, 2023

Conversation

sunnyyip
Copy link
Collaborator

Description of the PR

  • add healthcheck in docker compose services
  • remove local-healthcheck container

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@sunnyyip
use docker compose healthcheck
d867cde 
Signed-off-by: Sunny Yip <sunny@kusari.dev>
@kodiakhq kodiakhq bot merged commit 81e180b into guacsec:main Jun 16, 2023
8 checks passed
@sunnyyip sunnyyip deleted the update-docker-compose-healthcheck branch September 15, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@pxp928 pxp928 pxp928 approved these changes

@jeffmendoza jeffmendoza Awaiting requested review from jeffmendoza

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sunnyyip @mihaimaruseac @pxp928