Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spdlog_setup::spdlog_setup as the target in CMake config #22

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

jakecobb
Copy link
Contributor

@jakecobb jakecobb commented Jun 6, 2018

Fixes Issue #21

@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files           3        3           
  Lines         409      409           
=======================================
  Hits          360      360           
  Misses         49       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2606673...4f30b05. Read the comment docs.

Copy link
Owner

@guangie88 guangie88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this bug! 👍 Noted the namespace prepended when exporting spdlog_setup into spdlog_setup-targets.cmake.

@guangie88 guangie88 merged commit cb9a6ac into guangie88:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants