Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake config uses wrong target name #21

Closed
jakecobb opened this issue Jun 6, 2018 · 1 comment
Closed

CMake config uses wrong target name #21

jakecobb opened this issue Jun 6, 2018 · 1 comment
Labels
bug

Comments

@jakecobb
Copy link
Contributor

jakecobb commented Jun 6, 2018

Version 2.0 but I glanced at master and it seems to have the same issue.

spdlog_setup-target.cmake defines the spdlog_setup::spdlog_setup target, but spdlog_setup-config.cmake tries to reference the spdlog_setup target. This causes an error for my find_package on CMake 3.9.2. Manually editing spdlog_setup-config.cmake to reference spdlog_setup::spdlog_setup instead fixed it for me.
jakecobb added a commit to jakecobb/spdlog_setup that referenced this issue Jun 6, 2018
@jakecobb
Use spdlog_setup::spdlog_setup as the target in CMake config
4f30b05 
Fixes Issue guangie88#21
@jakecobb jakecobb mentioned this issue Jun 6, 2018
Merged
@guangie88 guangie88 mentioned this issue Jun 7, 2018
Open
@guangie88 guangie88 added the bug label Jun 7, 2018
guangie88 pushed a commit that referenced this issue Jun 7, 2018
@jakecobb @guangie88
Use spdlog_setup::spdlog_setup as the target in CMake config (#22)
cb9a6ac 
Fixes Issue #21
@guangie88
Copy link
Owner

guangie88 commented Jun 7, 2018 •
edited
Loading

Fixed by #22.

Works okay now if spdlog was found via find_package during the CMake config, rather than using submodule. See #23 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guangie88 @jakecobb