Undo previous patches (#17) #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2011 15:37
rymai
pushed a commit
that referenced
this pull request
May 4, 2011
Undo previous patches (#17): it was not tested (very bad!! ^^), and it actually didn't work as expected.
|
Ok, no problem. Do you think of an alternative? |
|
I've been thinking about it, but without changes to rspec, there is only one way I can think of. It's a little ugly though, because global state would be introduced: Basically we would need to set a flag in the formatter (probably with a new #start method that gets called once rspec starts running the specs) and then check the return code. If rspec failed and we did not set the flag, then rspec failed before loading the specs. If rspec failed and we did set the flag, then one or more of the specs failed. I'll ask on the rspec mailing list if there's another way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry, I should have tested this more thoroughly. So much for whipping up a quick fix. :(
Rspec's exit code does not differentiate between a failing spec and failing to run the specs. Kind of obvious in retrospect...