Skip to content

Commit

Permalink
Fix Travis CI build status image.
Browse files Browse the repository at this point in the history 
The image is not displayed properly because Travis SSL uses the
Heroku wildcard SSL certificate and is thus not trusted because
of the URL mismatch.
  • Loading branch information
@netzpirat
netzpirat committed Sep 3, 2011
1 parent 8bb295f commit 69d308b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Guard [![Build Status](https://travis-ci.org/guard/guard.png)](http://travis-ci.org/guard/guard)
Guard [![Build Status](http://travis-ci.org/guard/guard.png)](http://travis-ci.org/guard/guard)
=====

Guard is a command line tool that easily handle events on files modifications.
Expand Down

7 comments on commit 69d308b

@netzpirat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, Travis docs recommends to use SSL because of caching: http://about.travis-ci.org/docs/user/status-images/

The previous SSL enabled link didn't load the build status image with Firefox and Chrome. Did it with Safari?

@thibaudgg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works on Safari after going to the README page (https://github.com/guard/guard/blob/master/README.md) maybe it clear the github cache.

@rymai
Copy link
Member

@rymai rymai commented on 69d308b Sep 4, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change from "https://secure.travis-ci.org" to "https://travis-ci.org" in the first place?

Edit: Hum, it seems to redirect from "https://secure.travis-ci.org" to "https://travis-ci.org", that's why I guess.

@netzpirat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the issue in Travis: travis-ci/travis-ci#231

@rymai
Copy link
Member

@rymai rymai commented on 69d308b Sep 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! So once this is resolved, we should go back to "https://secure.travis-ci.org/guard/guard.png". :)

@netzpirat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. It's sometimes bothersome having a cached, wrong build status.

@rymai
Copy link
Member

@rymai rymai commented on 69d308b Sep 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when it's red, it's not cool! :D

Please sign in to comment.