-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release? #465
Comments
That's a totally legitimate request!
I can have a look on Monday unless someone else is faster. :)
Le ven. 27 sept. 2019 à 19:55, <notifications@github.com> a écrit :
… Is there anything I can do to help get a new release out the door? I'd
like to get the change that drops the ruby_dep dependency, which was
merged in over a year ago. Since it's still a dependency, it's printing out
false negatives about the level of support for my Ruby interpreter of
choice (TruffleRuby).
As an open source maintainer myself, I realize that asking for a new
release can be a touchy subject and is a thankless task. So, I sincerely
apologize if I've approached a sensitive topic. I also don't like
volunteering anyone else's time, so if there's some sort of release
qualification testing you need done, please just let me know.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#465?email_source=notifications&email_token=AAAAJEE63PQ4YIO46XD6GK3QLZCINA5CNFSM4I3JFIU2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOG35OA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAAJEEU5PX4FE76OMEXZDTQLZCINANCNFSM4I3JFIUQ>
.
|
If you add me as a maintainer of the org I can help with this. but you'd also need to add me as a gem owner. |
@ioquatix Done!
and done! ❤️ |
Done. |
Could we get release notes for 3.2.0? 🙏 |
Do you want to write it? |
The best place to start would be to look through the git commit history... I only checked briefly and confirmed all specs passing do this release. |
The reason I asked is because I believe it is important when publishing a release to rubygems that the release is always accompanied by a set of release notes. If the notes are absent it can give the impression that code is being pushed that the publishers don't understand or hasn't been thoroughly reviewed, which seems dangerous in light of recent gem malware discoveries. To be honest I do not feel comfortable writing the release notes myself since I am not a contributor and have no context as to the project's history or how the code is works. Are there no maintainers left that can do it? If not then I will give it a shot. |
I did review the code thoroughly but the best source of why changes occurred right now is |
I've tried a couple different approaches. One option is to have a CHANGELOG file that is updated with each PR. Before merging, each PR has to include an update to the CHANGELOG. I have used Danger (a GitHub bot) to automatically enforce this so that maintainers don't have to pester contributors about it. The problems with this approach are:
In short, it adds friction to the PR process. Also for The second option that I am using in my projects these days is using GitHub Actions and release-drafter. This updates the GitHub Release Notes whenever a PR is merged; it automatically adds a bullet point to the release with the PR title, PR number, and author. It can even group the release notes by section based on PR labels. Then when you publish a release you can use the automated draft as-is, or do any manual tweaks as needed. I'd be happy to set that up if you are interested in the latter approach. Here's how we set it up on capistrano: capistrano/capistrano#2034 |
The 2nd approach you propose makes total sense. Happy to have you do it. Let me see if I can give you access... |
@rymai would have to give you access, I'm not an admin. |
Can you make a PR? |
Yes, I'll make a PR this week. The owner of the |
Nope back to @rymai |
@mattbrictson Done, thanks! |
Sorry, haven't gotten to putting up a PR on this yet. Will try tomorrow. |
PR: #466 |
@ioquatix @rymai @mattbrictson Thank you all for the release! For the record, these are the (incorrect) warnings shown by
And the maintainer of I made a PR to update |
* https://github.com/guard/listen/releases/tag/v3.2.0 * guard/listen#465 * `listen` removed the unmaintained `ruby_dep` dependency, which incorrectly shows warnings when running on TruffleRuby.
* Backport of rails#37788 to 6.0-stable * https://github.com/guard/listen/releases/tag/v3.2.0 * guard/listen#465 * `listen` removed the unmaintained `ruby_dep` dependency, which incorrectly shows warnings when running on TruffleRuby.
Is there anything I can do to help get a new release out the door? I'd like to get the change that drops the
ruby_dep
dependency, which was merged in over a year ago. Since it's still a dependency, it's printing out false negatives about the level of support for my Ruby interpreter of choice (TruffleRuby).As an open source maintainer myself, I realize that asking for a new release can be a touchy subject and is a thankless task. So, I sincerely apologize if I've approached a sensitive topic. I also don't like volunteering anyone else's time, so if there's some sort of release qualification testing you need done, please just let me know.
The text was updated successfully, but these errors were encountered: