Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to listen 3.2 #38675

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Update to listen 3.2 #38675

merged 1 commit into from
Mar 8, 2020

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Mar 7, 2020

Summary

This is a backport of #37788 to 6.0-stable.

listen 3.2, among other fixes, removes the unmaintained ruby_dep dependency, which incorrectly shows warnings when running on TruffleRuby:

$ bundle exec rails s
RubyDep: WARNING: Your Ruby may not be supported.
RubyDep: WARNING: Your Ruby is: 2.6.2 'truffleruby' (unrecognized). If you need this version supported, please open an issue at http://github.com/e2/ruby_dep
RubyDep: WARNING: (To disable warnings, see:http://github.com/e2/ruby_dep/wiki/Disabling-warnings )
=> Booting Puma
=> Rails 6.0.1 application starting in development 
=> Run `rails server --help` for more startup options
Puma starting in single mode...
* Version 4.3.0 (truffleruby 19.3.0 - ruby 2.6.2), codename: Mysterious Traveller
* Min threads: 5, max threads: 5
* Environment: development
* Listening on tcp://127.0.0.1:3000
* Listening on tcp://[::1]:3000
Use Ctrl-C to stop

I am not aware of any issue by using a newer version of listen.

https://github.com/guard/listen/releases/tag/v3.2.0 are the release notes and guard/listen#465 is the issue asking for this new release.

ddddedc is the commit that added the < 3.2 version constraint. I guess that was just precaution (3.2 did not exist back then).

* Backport of rails#37788 to 6.0-stable
* https://github.com/guard/listen/releases/tag/v3.2.0
* guard/listen#465
* `listen` removed the unmaintained `ruby_dep` dependency, which
  incorrectly shows warnings when running on TruffleRuby.
@eregon eregon mentioned this pull request Mar 7, 2020
@kamipo kamipo merged commit aea09df into rails:6-0-stable Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants