New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport #383 #385
backport #383 #385
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -137,13 +137,43 @@ | |
allow(backend).to receive(:start) | ||
allow(processor).to receive(:setup) | ||
allow(processor).to receive(:resume) | ||
subject.start | ||
end | ||
|
||
it 'terminates' do | ||
allow(backend).to receive(:stop) | ||
allow(processor).to receive(:teardown) | ||
subject.stop | ||
context 'when fully started' do | ||
before do | ||
subject.start | ||
end | ||
|
||
it 'terminates' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
allow(backend).to receive(:stop) | ||
allow(processor).to receive(:teardown) | ||
subject.stop | ||
end | ||
end | ||
|
||
context 'when frontend is ready' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
before do | ||
subject.transition :backend_started | ||
subject.transition :frontend_ready | ||
end | ||
|
||
it 'terminates' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
allow(backend).to receive(:stop) | ||
allow(processor).to receive(:teardown) | ||
subject.stop | ||
end | ||
end | ||
|
||
context 'when only backend is already started' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
before do | ||
subject.transition :backend_started | ||
end | ||
|
||
it 'terminates' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
||
allow(backend).to receive(:stop) | ||
allow(processor).to receive(:teardown) | ||
subject.stop | ||
end | ||
end | ||
end | ||
|
||
|
@@ -304,17 +334,4 @@ | |
end | ||
end | ||
end | ||
|
||
describe 'processing changes' do | ||
before do | ||
allow(backend).to receive(:start) | ||
end | ||
end | ||
|
||
context 'when listener is stopped' do | ||
before do | ||
subject.stop | ||
allow(silencer).to receive(:silenced?) { true } | ||
end | ||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.