Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #383 #385

Merged
merged 2 commits into from
Apr 30, 2016
Merged

backport #383 #385

merged 2 commits into from
Apr 30, 2016

Conversation

e2
Copy link
Contributor

@e2 e2 commented Apr 30, 2016

  • allow stopping when not fully initialized
  • remove unused spec code

houndci-bot
houndci-bot reviewed Apr 30, 2016
View reviewed changes
spec/lib/listen/listener_spec.rb
subject.transition :backend_started
end

it 'terminates' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@coveralls
Copy link

coveralls commented Apr 30, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 97.843% when pulling d0ce6c6 on backport_383_fix_transition_to_stopped into 2b60237 on v3.0.

@e2 e2 merged commit 01a028a into v3.0 Apr 30, 2016
@e2 e2 deleted the backport_383_fix_transition_to_stopped branch April 30, 2016 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e2 @coveralls @houndci-bot