Remove Listen::Internals::ThreadPool #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@listeners` variable holds a reference to each `Listener` instance created by `Listen.to` and can only be cleared by calling `Listen.stop`. This can prevent `Listener` instances from being garbage collected if they are abandoned before `Listen.stop` is called. This commit wraps `Listener` instances in `WeakRef` before adding them to `@listeners`, to allow them to be garbage collected. Partially addresses guard#476.
houndci-bot
reviewed
Jul 23, 2020
| # You can't kill a thread that is doing a sysread in JRuby, so | ||
| # skip `join` and pray thread dies fast... | ||
| if RUBY_ENGINE == 'jruby' | ||
| @run_thread.kill if (@run_thread ||= nil) |
There was a problem hiding this comment.
Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an if.
| @@ -99,7 +97,15 @@ def _dir_event?(event) | |||
| end | |||
|
|
|||
| def _stop | |||
| @worker && @worker.close | |||
| @worker.close if (@worker ||= nil) | |||
There was a problem hiding this comment.
Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an if.
| @@ -74,6 +73,11 @@ def _run_worker(worker) | |||
| format_string = 'fsevent: running worker failed: %s:%s called from: %s' | |||
| _log_exception format_string, caller | |||
| end | |||
|
|
|||
| def _stop | |||
| @worker_thread.kill.join if (@worker_thread ||= nil) | |||
There was a problem hiding this comment.
Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an if.
| @@ -96,6 +96,7 @@ def self.usable? | |||
| private | |||
|
|
|||
| def _stop | |||
| @run_thread.kill.join if (@run_thread ||= nil) | |||
There was a problem hiding this comment.
Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an if.
jonathanhefner
force-pushed
the
remove-thread_pool
branch
from
f9f26c2
to
5fcb42d
Compare
`Listen::Internals::ThreadPool` manages all listener threads. Thus the only way to kill and subsequently garbage collect listener threads is by calling the `Listen::Internals::ThreadPool.stop` method (typically done via `Listen.stop`). This is a problem when individual listeners must be stopped and abandoned for garbage collection. This commit removes `Listen::Internals::ThreadPool` in favor of listener instances managing their own threads. Partially addresses guard#476.
jonathanhefner
force-pushed
the
remove-thread_pool
branch
from
5fcb42d
to
05ac45f
Compare
ioquatix
approved these changes
Aug 23, 2020
|
I am manually rebasing and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen::Internals::ThreadPoolmanages all listener threads. Thus the only way to kill and subsequently garbage collect listener threads is by calling theListen::Internals::ThreadPool.stopmethod (typically done viaListen.stop). This is a problem when individual listeners must be stopped and abandoned for garbage collection.This commit removes
Listen::Internals::ThreadPoolin favor of listener instances managing their own threads.Partially addresses #476.
/cc @headius
This is based on top of #477, so that should probably be merged first. Together, these PRs fix #476.