Wrap Listener instances in WeakRef #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@listeners
variable holds a reference to eachListener
instance created byListen.to
and can only be cleared by callingListen.stop
. This can preventListener
instances from being garbage collected if they are abandoned beforeListen.stop
is called.This commit wraps
Listener
instances inWeakRef
before adding them to@listeners
, to allow them to be garbage collected.Partially addresses #476.