issue #497: unify logging through Listen.logger; add missing logger_spec #498

ColinDKelley · 2020-09-20T17:10:02Z

Issue #497

Unified all logging through Listen.logger. No need for private methods, public_send, or meta-code.
Removed comment about "clearing" the logger (this wasn't supported); added comment about setting logger to /dev/null if you don't want logging.
Added missing logger_spec including testing all supported values for LISTEN_GEM_DEBUGGING. Extended that support to include the string forms of all the useful levels: debug, info, warn, error, fatal.

spec/lib/listen/logger_spec.rb

lib/listen/event/loop.rb

lib/listen/adapter/windows.rb

lib/listen/adapter/base.rb

lib/listen/adapter.rb

…ger_spec

houndci-bot reviewed Sep 20, 2020

View reviewed changes

ColinDKelley requested a review from ioquatix October 14, 2020 03:54

ioquatix approved these changes Oct 30, 2020

View reviewed changes

issue guard#497: unify logging through Listen.logger; add missing log…

49381cf

…ger_spec

ColinDKelley force-pushed the issue_497/unify-logging branch from 330f179 to 49381cf Compare October 30, 2020 06:17

ColinDKelley merged commit 49381cf into guard:master Oct 30, 2020

ColinDKelley deleted the issue_497/unify-logging branch October 30, 2020 06:18

ColinDKelley linked an issue Oct 30, 2020 that may be closed by this pull request

logging should be unified #497

Closed

Provide feedback