Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump multimatch and braces deps #478

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Bump multimatch and braces deps #478

merged 3 commits into from
Jun 6, 2024

Conversation

tjmw
Copy link
Member

@tjmw tjmw commented Jun 5, 2024

What does this change?

Vulnerabilities have been reported for the transitive dependencies braces and multimatch. This PR bumps them both. In most cases new (non-vulnerable) versions satisfied the existing dependency range.

In one case much older versions were being pulled in by @storybook/preset-typescript, but this no longer seems to be used so I've removed it.

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: ea5a5a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tjmw tjmw changed the base branch from main to tw/fix-chromatic June 5, 2024 16:22
@tjmw tjmw marked this pull request as ready for review June 5, 2024 16:22
Copy link
Contributor

@rBangay rBangay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from tw/fix-chromatic to main June 6, 2024 08:16
tjmw added 3 commits June 6, 2024 09:17
Here the non-vulnerable versions (3.0.2 and 4.0.5) can easily be
replaces by non-vulnerable versions.
It doesn't seem to be needed and is the source of some old lib
dependencies being pulled in (micromatch and braces).
Here the non-vulnerable versions (3.0.2 and 4.0.5) can easily be
replaces by non-vulnerable versions.
@tjmw tjmw merged commit 09dc6f0 into main Jun 6, 2024
7 checks passed
@tjmw tjmw deleted the tw/vulnerabilities branch June 6, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants