-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PR check for average time to load top-above-nav #1363
Conversation
|
steps: | ||
# Commercial | ||
- name: Checkout | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkout@v4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this change?
Adds a new workflow to PR checks to check the average time for top-above-nav to load over 20 articles. We're using a high number of articles to hopefully average out the effects of any anomalous results. You can view the result by clicking on the details for the Test ad load time check and checking the average ad render time value under the Run Playwright step.
It would be nice to add the result of this check as a comment on the PR in future, but maybe that would be a good improvement for the future as it isn't necessary now.
Why?
It'll be useful to have a quick indication of whether a change might speed up or slow down the first ad appearing on the page. Hopefully this added check can give an 'at-a-glance' view of the potential impact of a change.