Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR check for average time to load top-above-nav #1363

Merged
merged 20 commits into from
May 15, 2024
Merged

Add PR check for average time to load top-above-nav #1363

merged 20 commits into from
May 15, 2024

Commits on May 7, 2024

  1. Add test to check average ad load time

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    02312b7 View commit details
    Browse the repository at this point in the history

  2. Add puppeteer browser install step

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    413bb4a View commit details
    Browse the repository at this point in the history

  3. Install chromium

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f6113fa View commit details
    Browse the repository at this point in the history

  4. Make sure to run puppeteer install step

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    80806ca View commit details
    Browse the repository at this point in the history

  5. Slower network conditions

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b09daeb View commit details
    Browse the repository at this point in the history

  6. Move articles

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    38c675d View commit details
    Browse the repository at this point in the history

  7. Move articles and update CDP session command

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    3e736e3 View commit details
    Browse the repository at this point in the history

  8. Even worse network conditions

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    a505ba9 View commit details
    Browse the repository at this point in the history

  9. Use playwright test instead

    @emma-imber
    emma-imber committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cf8e298 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Separate out ad-load speed from other playwright tests

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    87e36aa View commit details
    Browse the repository at this point in the history

  2. Rename files

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    49dc53a View commit details
    Browse the repository at this point in the history

  3. Increase to test 20 articles for better repeatability

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7f97a6f View commit details
    Browse the repository at this point in the history

  4. Test worse network conditions to make sure they affect ad load time

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    ee1d6b0 View commit details
    Browse the repository at this point in the history

  5. Comment out network conditions emulation

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    82b326a View commit details
    Browse the repository at this point in the history

  6. Add comments and tidy up

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    1929387 View commit details
    Browse the repository at this point in the history

  7. Change artifact upload location

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    662426e View commit details
    Browse the repository at this point in the history

  8. Try worse web speeds

    @emma-imber
    emma-imber committed May 8, 2024
    Configuration menu
    Copy the full SHA
    8d92f7d View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Checkout v4

    @emma-imber
    emma-imber committed May 13, 2024
    Configuration menu
    Copy the full SHA
    451bf29 View commit details
    Browse the repository at this point in the history

  2. Use set up node env action

    @emma-imber
    emma-imber committed May 13, 2024
    Configuration menu
    Copy the full SHA
    16ae764 View commit details
    Browse the repository at this point in the history

  3. Remove working directory references

    @emma-imber
    emma-imber committed May 13, 2024
    Configuration menu
    Copy the full SHA
    93872ff View commit details
    Browse the repository at this point in the history