Skip to content

Commit

Permalink
refactor: Switch to using an auto-generated riff-raff.yaml file
Browse files Browse the repository at this point in the history
  • Loading branch information
akash1810 committed Oct 28, 2022
1 parent ac62022 commit 595ed5f
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 99 deletions.
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,9 @@ target

# Yarn
.yarn/*

# riff-raff.yaml is auto-generated by @guardian/cdk into `cdk/cdk.out/riff-raff.yaml`.
# It's copied to the root of the repository for @guardian/node-riffraff-artifact.
# As it's generated, we don't need to track it in VCS.
# TODO move to https://github.com/guardian/actions-riff-raff in place of @guardian/node-riffraff-artifactt to remove this oddity
riff-raff.yaml
9 changes: 2 additions & 7 deletions artifact.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,8 @@
"vcsURL": "https://github.com/guardian/consent-management-platform",
"actions": [
{
"action": "cmp-monitoring-lambda-eu-west-1",
"path": "monitoring/dist",
"compress": "zip"
},
{
"action": "cloud-formation",
"path": "cdk/cdk.out/",
"action": "cdk.out",
"path": "cdk/cdk.out",
"compress": false
},
{
Expand Down
4 changes: 2 additions & 2 deletions cdk/bin/cdk.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import 'source-map-support/register';
import type { GuStackProps } from '@guardian/cdk/lib/constructs/core';
import { App } from 'aws-cdk-lib';
import { GuRootExperimental } from '@guardian/cdk/lib/experimental/constructs/root';
import { Monitoring } from '../lib/monitoring';

const app = new App();
const app = new GuRootExperimental();

const regionNames = [
'eu-west-1',
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"types": "tsc --project ./tsconfig.build.json",
"validate": "npm-run-all tsc test lint build",
"prepare": "husky install",
"ci:monitoring": "yarn run node-riffraff-artifact"
"ci:monitoring": "cp cdk/cdk.out/riff-raff.yaml riff-raff.yaml && yarn run node-riffraff-artifact"
},
"prettier": "@guardian/prettier",
"devDependencies": {
Expand Down
89 changes: 0 additions & 89 deletions riff-raff.yaml

This file was deleted.

0 comments on commit 595ed5f

Please sign in to comment.