refactor: Moving from using title text to using apparently-unique class names to identify SourcePoint buttons #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the test more robust when doing ab tests that change the text on the button - at least until Sourcepoint add an id to the button
this makes the test more stable during ab testing
Updated test for Interacting with CMPbanner in CCPA
sookburt
changed the title
kenoir
reviewed
Sep 28, 2022
kenoir
approved these changes
Sep 29, 2022
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Alters the monitoring test to use class names to identify the buttons within Sourcepoint's CMP in the absence of HTML element ids.
Why?
This fixes the issue that ab tests often change the text of the button which we were previously relying on. It makes the monitoring tests slightly less fragile until we can persuade Sourcepoint to add ids into their code. (we hope).
Sue Burt and Akinsola Lawanson