Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Moving from using title text to using apparently-unique class names to identify SourcePoint buttons #667

Merged
merged 4 commits into from
Oct 4, 2022
Merged

refactor: Moving from using title text to using apparently-unique class names to identify SourcePoint buttons #667

merged 4 commits into from
Oct 4, 2022

Commits on Sep 26, 2022

  1. change button click selector to use Sourcepoint class 

    This should make the test more robust when doing ab tests that change the text on the button - at least until Sourcepoint add an id to the button
    @sookburt
    sookburt committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    06f8b7c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. change to using class name for selecting button 

    this makes the test more stable during ab testing
    @sookburt
    sookburt committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    59a127b View commit details
    Browse the repository at this point in the history

  2. Update ccpa.ts 

    Updated test for Interacting with CMPbanner in CCPA
    @akinsola-guardian
    akinsola-guardian committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    817905c View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. changed method names to make clearer what is happening following feed… 

    …back
    @sookburt
    sookburt committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    44691d4 View commit details
    Browse the repository at this point in the history