Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime id to monitoring #995

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented May 24, 2024

What does this change?

Adding the runtime id to the cdk. Removing the runtime id secret

Why?

In this PR (#989), I added the lambda node js runtime id as a secret. This has made local testing more difficult without actually removing the id from the repo (monitoring cdk snapshot)

Link to Trello

Copy link

changeset-bot bot commented May 24, 2024

⚠️ No Changeset found

Latest commit: b262f68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@akinsola-guardian akinsola-guardian marked this pull request as ready for review May 24, 2024 10:15
@akinsola-guardian akinsola-guardian requested a review from a team as a code owner May 24, 2024 10:15
Copy link

@raphaelkabo raphaelkabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@akinsola-guardian akinsola-guardian merged commit 39d58eb into main May 24, 2024
11 checks passed
@akinsola-guardian akinsola-guardian deleted the al-remove-from-arn-secret branch May 24, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants