Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Monitoring by defining the NodeJS runtime version #989

Merged
merged 6 commits into from
May 23, 2024
Merged

Fix Monitoring by defining the NodeJS runtime version #989

merged 6 commits into from
May 23, 2024

Conversation

akinsola-guardian
Copy link
Contributor

@akinsola-guardian akinsola-guardian commented May 16, 2024 •
edited
Loading

What does this change?

  • Update playwright
  • Fixing the runtime version to previous Lambda Runtime ARN.

Why?

The automatic update is incompatible with playwright-aws-lambda

JupiterOne/playwright-aws-lambda#74

Tested in CODE

Link to Trello

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e93204e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

Deploy build 2070 of consent::cmp-monitoring to CODE

All deployment options

From guardian/actions-riff-raff.

@akinsola-guardian akinsola-guardian changed the title Update playwright Fix Monitoring May 16, 2024
@akinsola-guardian akinsola-guardian changed the title Fix Monitoring Fix Monitoring by defining the NodeJS runtime version May 16, 2024
@akinsola-guardian akinsola-guardian marked this pull request as ready for review May 16, 2024 14:04
@akinsola-guardian akinsola-guardian requested a review from a team as a code owner May 16, 2024 14:04
coldlink
coldlink previously approved these changes May 20, 2024
View reviewed changes
@akinsola-guardian akinsola-guardian merged commit a74c200 into main May 23, 2024
12 checks passed
@akinsola-guardian akinsola-guardian deleted the al-update-playwright branch May 23, 2024 15:42
@akinsola-guardian akinsola-guardian mentioned this pull request May 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coldlink coldlink coldlink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akinsola-guardian @coldlink