Display a file limit warning where applicable #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6cc6c8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
abeddow91
force-pushed
the
ab/add-limit-warning-to-file-input
branch
from
4ff0651
to
3ea67a7
Compare
mxdvl
reviewed
Feb 14, 2024
libs/@guardian/source-react-components-development-kitchen/src/file-input/FileInput.tsx
Outdated
Show resolved
Hide resolved
libs/@guardian/source-react-components-development-kitchen/src/file-input/FileInput.stories.tsx
Show resolved
Hide resolved
libs/@guardian/source-react-components-development-kitchen/src/file-input/FileInput.tsx
Outdated
Show resolved
Hide resolved
abeddow91
force-pushed
the
ab/add-limit-warning-to-file-input
branch
from
3ea67a7
to
00a851e
Compare
mxdvl
approved these changes
Feb 14, 2024
abeddow91
force-pushed
the
ab/add-limit-warning-to-file-input
branch
2 times, most recently
from
f1534a6
to
d96b4f9
Compare
abeddow91
force-pushed
the
ab/add-limit-warning-to-file-input
branch
from
d96b4f9
to
6cc6c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Adds a file limit warning underneath the supporting text on file input if a max file size has been provided.
Why?
If there is a file size limit, this should be shown to the user before they try and upload a file.