Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove source eslint plugins #1475

Merged
merged 2 commits into from
May 23, 2024
Merged

Remove source eslint plugins #1475

merged 2 commits into from
May 23, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 22, 2024

What are you changing?

Removing the source eslint plugins from the repo.

Why?

They've not been updated since they automated the move from v3v4 and don't check anything else.

They also don't apply the new single source package.

they've not been updated since v3 → v4 and don't check anything. they also dont' apply the new single source package
@sndrs sndrs requested review from a team as code owners May 22, 2024 15:38
Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: a35e7a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sndrs sndrs self-assigned this May 22, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 22, 2024
@sndrs sndrs added run_chromatic Runs chromatic when label is applied and removed 📦 npm Affects a @guardian package on NPM labels May 22, 2024
@jamesmockett
Copy link
Contributor

There are a couple of references in CODEOWNERS that could be removed too.

@sndrs sndrs enabled auto-merge (squash) May 23, 2024 08:59
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 23, 2024
@sndrs sndrs merged commit cc5259f into main May 23, 2024
20 checks passed
@sndrs sndrs deleted the sndrs/remove-source-eslint-plugins branch May 23, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants