Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove source eslint plugins #1475

Merged
merged 2 commits into from
May 23, 2024
Merged

Remove source eslint plugins #1475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
211fe72
remove source eslint plugins
sndrs May 22, 2024
a35e7a9
remove refs to the plugins
sndrs May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
/libs/@guardian/source-foundations/ @guardian/client-side-infra @guardian/source
/libs/@guardian/source-react-components/ @guardian/client-side-infra @guardian/source
/libs/@guardian/source-react-components-development-kitchen/ @guardian/client-side-infra @guardian/source
/libs/@guardian/eslint-plugin-source-foundations/ @guardian/client-side-infra @guardian/source
/libs/@guardian/eslint-plugin-source-react-components/ @guardian/client-side-infra @guardian/source

/libs/@guardian/browserlist-config/ @guardian/client-side-infra @guardian/dotcom-platform

Expand Down
48 changes: 0 additions & 48 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,54 +257,6 @@ install: check-node-version
@guardian/eslint-config-typescript\:lint: env
@corepack pnpm --filter @guardian/eslint-config-typescript lint

.PHONY: @guardian/eslint-plugin-source-foundations\:build
@guardian/eslint-plugin-source-foundations\:build: env
@corepack pnpm --filter @guardian/eslint-plugin-source-foundations build

.PHONY: @guardian/eslint-plugin-source-foundations\:dev
@guardian/eslint-plugin-source-foundations\:dev: env
@corepack pnpm --filter @guardian/eslint-plugin-source-foundations dev

.PHONY: @guardian/eslint-plugin-source-foundations\:fix
@guardian/eslint-plugin-source-foundations\:fix: env
@corepack pnpm --filter @guardian/eslint-plugin-source-foundations fix

.PHONY: @guardian/eslint-plugin-source-foundations\:lint
@guardian/eslint-plugin-source-foundations\:lint: env
@corepack pnpm --filter @guardian/eslint-plugin-source-foundations lint

.PHONY: @guardian/eslint-plugin-source-foundations\:test
@guardian/eslint-plugin-source-foundations\:test: env
@corepack pnpm --filter @guardian/eslint-plugin-source-foundations test

.PHONY: @guardian/eslint-plugin-source-foundations\:verify-dist
@guardian/eslint-plugin-source-foundations\:verify-dist: env
@corepack pnpm --filter @guardian/eslint-plugin-source-foundations verify-dist

.PHONY: @guardian/eslint-plugin-source-react-components\:build
@guardian/eslint-plugin-source-react-components\:build: env
@corepack pnpm --filter @guardian/eslint-plugin-source-react-components build

.PHONY: @guardian/eslint-plugin-source-react-components\:dev
@guardian/eslint-plugin-source-react-components\:dev: env
@corepack pnpm --filter @guardian/eslint-plugin-source-react-components dev

.PHONY: @guardian/eslint-plugin-source-react-components\:fix
@guardian/eslint-plugin-source-react-components\:fix: env
@corepack pnpm --filter @guardian/eslint-plugin-source-react-components fix

.PHONY: @guardian/eslint-plugin-source-react-components\:lint
@guardian/eslint-plugin-source-react-components\:lint: env
@corepack pnpm --filter @guardian/eslint-plugin-source-react-components lint

.PHONY: @guardian/eslint-plugin-source-react-components\:test
@guardian/eslint-plugin-source-react-components\:test: env
@corepack pnpm --filter @guardian/eslint-plugin-source-react-components test

.PHONY: @guardian/eslint-plugin-source-react-components\:verify-dist
@guardian/eslint-plugin-source-react-components\:verify-dist: env
@corepack pnpm --filter @guardian/eslint-plugin-source-react-components verify-dist

.PHONY: @guardian/identity-auth\:build
@guardian/identity-auth\:build: env
@corepack pnpm --filter @guardian/identity-auth build
Expand Down
20 changes: 0 additions & 20 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ The following packages live in `libs/@guardian/*` and are published to NPM:
- [@guardian/core-web-vitals](libs/@guardian/core-web-vitals)
- [@guardian/eslint-config](libs/@guardian/eslint-config)
- [@guardian/eslint-config-typescript](libs/@guardian/eslint-config-typescript)
- [@guardian/eslint-plugin-source-foundations](libs/@guardian/eslint-plugin-source-foundations)
- [@guardian/eslint-plugin-source-react-components](libs/@guardian/eslint-plugin-source-react-components)
- [@guardian/identity-auth](libs/@guardian/identity-auth)
- [@guardian/identity-auth-frontend](libs/@guardian/identity-auth-frontend)
- [@guardian/libs](libs/@guardian/libs)
Expand Down Expand Up @@ -129,24 +127,6 @@ Project-specific tasks are defined as `scripts` in a `package.json` or `targets`
- `make @guardian/eslint-config-typescript:fix`
- `make @guardian/eslint-config-typescript:lint`

#### @guardian/eslint-plugin-source-foundations

- `make @guardian/eslint-plugin-source-foundations:build`
- `make @guardian/eslint-plugin-source-foundations:dev`
- `make @guardian/eslint-plugin-source-foundations:fix`
- `make @guardian/eslint-plugin-source-foundations:lint`
- `make @guardian/eslint-plugin-source-foundations:test`
- `make @guardian/eslint-plugin-source-foundations:verify-dist`

#### @guardian/eslint-plugin-source-react-components

- `make @guardian/eslint-plugin-source-react-components:build`
- `make @guardian/eslint-plugin-source-react-components:dev`
- `make @guardian/eslint-plugin-source-react-components:fix`
- `make @guardian/eslint-plugin-source-react-components:lint`
- `make @guardian/eslint-plugin-source-react-components:test`
- `make @guardian/eslint-plugin-source-react-components:verify-dist`

#### @guardian/identity-auth

- `make @guardian/identity-auth:build`
Expand Down
5 changes: 0 additions & 5 deletions docs/source/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ There are three main Source packages:
- [`@guardian/source-react-components`](../../libs/@guardian/source-react-components/README.md): A set of robust, accessible React components built using @guardian/source-foundations
- [`@guardian/source-react-components-development-kitchen`](../../libs/@guardian/source-react-components-development-kitchen/README.md): The Development Kitchen is where new components and patterns can be cooked up, tested and shared. There are minimal acceptance criteria. It’s okay to duplicate and break things. If a Kitchen component proves valuable, it may be promoted to `@guardian/source-react-components`

In addition there are two ESLint plugins:

- [`@guardian/eslint-plugin-source-foundations`](../../libs/@guardian/eslint-plugin-source-foundations/README.md): ESLint plugin for Guardian projects using the `@guardian/source-foundations` package
- [`@guardian/eslint-plugin-source-react-components`](../../libs/@guardian/eslint-plugin-source-react-components/README.md): ESLint plugin for Guardian projects using the `@guardian/source-react-components` package

## Contributing

We welcome contributions to Source! See our [contributing](contributing.md) and [Storybook](storybook.md) docs for more info.
39 changes: 0 additions & 39 deletions libs/@guardian/eslint-plugin-source-foundations/.eslintrc.cjs
View file
Open in desktop

This file was deleted.

206 changes: 0 additions & 206 deletions libs/@guardian/eslint-plugin-source-foundations/CHANGELOG.md
View file
Open in desktop

This file was deleted.

Loading