Sort package.json in new Source packages
#1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
|
Although we probably want the comment as the first thing in the file. Should we exclude these from the pre-commit hook instead? |
sndrs
reviewed
May 28, 2024
sndrs
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
package.jsonfiles in new Source packages by runningsort-package-json.Why?
sort-package-jsonruns as a pre-commit hook. Merging frommaininto branches that existed before these new packages were created may cause these changes to be applied there depending on what files have been touched. It makes sense to apply these changes in a single place rather than an unrelated branch.