Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some types issues in storybook #1539

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix some types issues in storybook #1539

merged 1 commit into from
Jun 13, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Jun 13, 2024

What are you changing?

  • fixes some types issues in stories

Why?

prep for adding wider type checking

@sndrs sndrs requested review from a team as code owners June 13, 2024 11:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2024

⚠️ No Changeset found

Latest commit: a4fda0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jun 13, 2024
SiAdcock
SiAdcock approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@SiAdcock SiAdcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff 💎

@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Jun 13, 2024
@sndrs sndrs enabled auto-merge (squash) June 13, 2024 13:18
@sndrs sndrs merged commit efb0bc6 into main Jun 13, 2024
20 checks passed
@sndrs sndrs deleted the sndrs/storybook-types-fixes branch June 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiAdcock SiAdcock SiAdcock approved these changes

Assignees
No one assigned
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sndrs @SiAdcock