Add new units to spacing scale #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3965eba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sndrs
approved these changes
Nov 10, 2023
jamesmockett
added a commit
that referenced
this pull request
May 31, 2024
## What are you changing? - Use the common `Space` type in components that accept spacing values as props. - Fixes a bug where spacing styles are not applied if `space.0` is used due to `0` being falsy. - Update `Stack` stories to better show how spacing is applied. - Expands `Inline` and `Stack` stories to include examples of _all_ spacing values. <img width="654" alt="Screenshot 2024-05-08 at 15 00 27" src="https://github.com/guardian/csnx/assets/1166188/658fe4a8-ed26-4d8b-a037-84927618290e"> ## Why? - It removes a small amount of duplication and avoids having to update spacing values in multiple places. [New spacing values were added last year](#897), but some components still lack support for these as their types were not updated at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing?
Adds new spacing units to maintain parity with Figma.
Why?
The spacing scale has diverged from what the design team are working with in Figma so engineers are being given designs which use spacing units not available in
source-foundations, forcing them to hardcode spacing values rather than use the system.