Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Source spacing tokens #888

Closed
jamesmockett opened this issue Oct 31, 2023 · 0 comments · Fixed by #897
Closed

Update Source spacing tokens #888

jamesmockett opened this issue Oct 31, 2023 · 0 comments · Fixed by #897
Assignees
@jamesmockett

Comments

@jamesmockett
Copy link
Contributor

jamesmockett commented Oct 31, 2023 •
edited
Loading

The spacing tokens in Source Foundations have diverged from Figma: new values have been added and token names updated. eg. space[4] is now spacing.060.

We may need to work with the Design System team to tweak the names as spacing.060 cannot be represented directly in JS. We should also deprecate the existing tokens and, if possible, add a rule to eslint-plugin-source-foundations to automatically update existing references to the old names.

https://theguardian.design/2a1e5182b/p/912e85-spacing/b/67c7d7
@jamesmockett jamesmockett self-assigned this Oct 31, 2023
@jamesmockett jamesmockett changed the title Updating spacing values and naming Update Source spacing tokens Oct 31, 2023
@jamesmockett jamesmockett linked a pull request Nov 10, 2023 that will close this issue
Add new units to spacing scale #897
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmockett jamesmockett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new units to spacing scale guardian/csnx
1 participant
@jamesmockett