Less article level css #1637
Merged
Less article level css #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlloyd
requested review from
gtrufitt,
jlieb10,
liywjl and
shtukas
as code owners
|
PRbuilds results: 💚 AMP validation LightHouse Reporting --automated message |
|
Size Change: -23 B (0%) Total Size: 514 kB
ℹ️ View Unchanged
|
gtrufitt
reviewed
Jun 22, 2020
| @@ -43,42 +43,6 @@ const bodyStyle = (display: Display) => css` | |||
| width: 100%; | |||
| height: auto; | |||
| } | |||
|
|
|||
| figure { | |||
There was a problem hiding this comment.
Is this completely removed because we don't have a figure used without styling being applied directly to the figure element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Deletes the 'global'
ulandlicss set at the article body level and drops it down to inside theTextBlockComponentWhy?
Because in photo essays the
ulandlitags are used to denote captions and we want to style them for that but this global pattern creates a css war. Rather than get in a fight I changed the scope of the original overrides to only apply to text blocks.