Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert single front door test #3982

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Revert single front door test #3982

merged 1 commit into from
Feb 14, 2022

Conversation

marialani
Copy link
Contributor

We're now ready to end the Single Front Door test so we can revert these changes.

Reverts #3832

@marialani marialani marked this pull request as draft February 14, 2022 10:28
@github-actions
Copy link

Size Change: -237 B (0%)

Total Size: 1.27 MB

Filename Size Change
dotcom-rendering/dist/1924.js 5.03 kB -75 B (-1%)
dotcom-rendering/dist/1924.legacy.js 5.11 kB -76 B (-1%)
dotcom-rendering/dist/frontend.server.js 319 kB -194 B (0%)
dotcom-rendering/dist/react.js 73.5 kB +39 B (0%)
dotcom-rendering/dist/react.legacy.js 80 kB +69 B (0%)
ℹ️ View Unchanged
Filename Size
dotcom-rendering/dist/1214.js 2.65 kB
dotcom-rendering/dist/1214.legacy.js 2.71 kB
dotcom-rendering/dist/1376.js 1.9 kB
dotcom-rendering/dist/1376.legacy.js 2.01 kB
dotcom-rendering/dist/1624.js 2.64 kB
dotcom-rendering/dist/1624.legacy.js 2.71 kB
dotcom-rendering/dist/2.js 4.36 kB
dotcom-rendering/dist/2.legacy.js 4.47 kB
dotcom-rendering/dist/2058.js 5.78 kB
dotcom-rendering/dist/2058.legacy.js 5.94 kB
dotcom-rendering/dist/2177.js 3.7 kB
dotcom-rendering/dist/262.js 5.61 kB
dotcom-rendering/dist/2666.js 30.8 kB
dotcom-rendering/dist/2727.legacy.js 28.7 kB
dotcom-rendering/dist/2879.js 9.01 kB
dotcom-rendering/dist/2879.legacy.js 9.56 kB
dotcom-rendering/dist/2947.js 2.58 kB
dotcom-rendering/dist/2947.legacy.js 2.66 kB
dotcom-rendering/dist/3203.js 9.16 kB
dotcom-rendering/dist/3203.legacy.js 9.64 kB
dotcom-rendering/dist/3213.js 13.5 kB
dotcom-rendering/dist/3213.legacy.js 13.8 kB
dotcom-rendering/dist/3215.js 5.39 kB
dotcom-rendering/dist/3215.legacy.js 5.52 kB
dotcom-rendering/dist/3397.js 240 B
dotcom-rendering/dist/3397.legacy.js 251 B
dotcom-rendering/dist/3729.js 1.28 kB
dotcom-rendering/dist/3729.legacy.js 1.37 kB
dotcom-rendering/dist/4025.js 3.98 kB
dotcom-rendering/dist/4025.legacy.js 4.31 kB
dotcom-rendering/dist/4211.js 2 kB
dotcom-rendering/dist/4211.legacy.js 2.11 kB
dotcom-rendering/dist/4576.js 235 B
dotcom-rendering/dist/4576.legacy.js 247 B
dotcom-rendering/dist/4813.js 5.29 kB
dotcom-rendering/dist/4813.legacy.js 5.38 kB
dotcom-rendering/dist/4850.js 235 B
dotcom-rendering/dist/4850.legacy.js 246 B
dotcom-rendering/dist/4999.js 18.4 kB
dotcom-rendering/dist/4999.legacy.js 19 kB
dotcom-rendering/dist/5096.js 4.67 kB
dotcom-rendering/dist/5096.legacy.js 4.74 kB
dotcom-rendering/dist/5217.js 233 B
dotcom-rendering/dist/5217.legacy.js 245 B
dotcom-rendering/dist/53.js 4.11 kB
dotcom-rendering/dist/53.legacy.js 4.12 kB
dotcom-rendering/dist/5356.js 5.5 kB
dotcom-rendering/dist/5356.legacy.js 5.65 kB
dotcom-rendering/dist/5585.js 6.47 kB
dotcom-rendering/dist/5585.legacy.js 6.72 kB
dotcom-rendering/dist/6046.js 2.94 kB
dotcom-rendering/dist/6046.legacy.js 3.04 kB
dotcom-rendering/dist/6348.js 5.12 kB
dotcom-rendering/dist/6348.legacy.js 5.29 kB
dotcom-rendering/dist/6400.js 21.5 kB
dotcom-rendering/dist/6400.legacy.js 21.5 kB
dotcom-rendering/dist/6684.js 241 B
dotcom-rendering/dist/6684.legacy.js 252 B
dotcom-rendering/dist/6965.js 3.18 kB
dotcom-rendering/dist/6965.legacy.js 3.24 kB
dotcom-rendering/dist/6992.js 2.02 kB
dotcom-rendering/dist/6992.legacy.js 2.12 kB
dotcom-rendering/dist/7051.js 7.76 kB
dotcom-rendering/dist/7051.legacy.js 7.91 kB
dotcom-rendering/dist/7642.legacy.js 8.31 kB
dotcom-rendering/dist/7671.legacy.js 3.83 kB
dotcom-rendering/dist/7800.js 11 kB
dotcom-rendering/dist/8080.js 1.81 kB
dotcom-rendering/dist/8080.legacy.js 1.9 kB
dotcom-rendering/dist/8129.legacy.js 11.5 kB
dotcom-rendering/dist/8294.js 232 B
dotcom-rendering/dist/8294.legacy.js 244 B
dotcom-rendering/dist/831.js 4.14 kB
dotcom-rendering/dist/831.legacy.js 4.45 kB
dotcom-rendering/dist/8748.js 232 B
dotcom-rendering/dist/8748.legacy.js 243 B
dotcom-rendering/dist/9327.js 1.85 kB
dotcom-rendering/dist/9327.legacy.js 1.95 kB
dotcom-rendering/dist/9641.js 6.44 kB
dotcom-rendering/dist/9641.legacy.js 6.7 kB
dotcom-rendering/dist/9776.js 6.37 kB
dotcom-rendering/dist/9776.legacy.js 6.63 kB
dotcom-rendering/dist/9884.js 17 kB
dotcom-rendering/dist/9884.legacy.js 17.3 kB
dotcom-rendering/dist/9970.js 15.8 kB
dotcom-rendering/dist/9970.legacy.js 16.1 kB
dotcom-rendering/dist/atomIframe.js 1.87 kB
dotcom-rendering/dist/atomIframe.legacy.js 2.14 kB
dotcom-rendering/dist/bootCmp.js 7.39 kB
dotcom-rendering/dist/bootCmp.legacy.js 10.9 kB
dotcom-rendering/dist/braze-web-sdk-core.js 36.1 kB
dotcom-rendering/dist/braze-web-sdk-core.legacy.js 36.1 kB
dotcom-rendering/dist/cmp.js 7.51 kB
dotcom-rendering/dist/coreVitals.js 4.03 kB
dotcom-rendering/dist/coreVitals.legacy.js 4.33 kB
dotcom-rendering/dist/dynamicImport.js 3 kB
dotcom-rendering/dist/dynamicImport.legacy.js 3.29 kB
dotcom-rendering/dist/embedIframe.js 1.88 kB
dotcom-rendering/dist/embedIframe.legacy.js 2.14 kB
dotcom-rendering/dist/ga.js 3.88 kB
dotcom-rendering/dist/ga.legacy.js 4.14 kB
dotcom-rendering/dist/guardian-braze-components-banner.js 11.9 kB
dotcom-rendering/dist/guardian-braze-components-banner.legacy.js 12 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.js 8.11 kB
dotcom-rendering/dist/guardian-braze-components-end-of-article.legacy.js 8.18 kB
dotcom-rendering/dist/initDiscussion.js 7.77 kB
dotcom-rendering/dist/initDiscussion.legacy.js 8.03 kB
dotcom-rendering/dist/InteractiveBlockComponent.js 3.03 kB
dotcom-rendering/dist/InteractiveBlockComponent.legacy.js 3.18 kB
dotcom-rendering/dist/islands.js 7.93 kB
dotcom-rendering/dist/islands.legacy.js 8.66 kB
dotcom-rendering/dist/newsletterEmbedIframe.js 2.03 kB
dotcom-rendering/dist/newsletterEmbedIframe.legacy.js 2.29 kB
dotcom-rendering/dist/ophan.js 7.18 kB
dotcom-rendering/dist/ophan.legacy.js 7.38 kB
dotcom-rendering/dist/readerRevenueDevUtils.js 892 B
dotcom-rendering/dist/readerRevenueDevUtils.legacy.js 952 B
dotcom-rendering/dist/relativeTime.js 2.41 kB
dotcom-rendering/dist/relativeTime.legacy.js 2.68 kB
dotcom-rendering/dist/sentry.js 677 B
dotcom-rendering/dist/sentry.legacy.js 689 B
dotcom-rendering/dist/sentryLoader.js 4.75 kB
dotcom-rendering/dist/sentryLoader.legacy.js 7.71 kB
dotcom-rendering/dist/shimport.js 2.75 kB
dotcom-rendering/dist/shimport.legacy.js 2.76 kB
dotcom-rendering/dist/SignInGateMain.js 3.56 kB
dotcom-rendering/dist/SignInGateMain.legacy.js 3.69 kB
dotcom-rendering/dist/YoutubeBlockComponent.js 2.9 kB
dotcom-rendering/dist/YoutubeBlockComponent.legacy.js 3.03 kB

compressed-size-action

@marialani
Copy link
Contributor Author

Though we have re-added the footer it doesn't appear in the diff of the chromatic UI tests. Presumably this is the expected behaviour as the component is lazy loaded

@marialani marialani marked this pull request as ready for review February 14, 2022 12:19
@marialani marialani merged commit 680273e into main Feb 14, 2022
@marialani marialani deleted the mo-revert-single-front-door branch February 14, 2022 15:32
@mxdvl
Copy link
Contributor

mxdvl commented Mar 1, 2022

Though we have re-added the footer it doesn't appear in the diff of the chromatic UI tests. Presumably this is the expected behaviour as the component is lazy loaded
@marialani

Interestingly, it started appearing in #4126 🤷

@marialani
Copy link
Contributor Author

#4126

Though we have re-added the footer it doesn't appear in the diff of the chromatic UI tests. Presumably this is the expected behaviour as the component is lazy loaded
@marialani

Interestingly, it started appearing in #4126 🤷

Well would you look at that 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants