Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SFC to FC. SFC type is deprecated. #412

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Rename SFC to FC. SFC type is deprecated. #412

merged 1 commit into from
Feb 11, 2019

Conversation

gtrufitt
Copy link
Contributor

@gtrufitt gtrufitt commented Feb 7, 2019

What does this change?

As title.

Why?

DefinitelyTyped/DefinitelyTyped#30364

@PRBuilds
Copy link

PRBuilds commented Feb 7, 2019

PRbuilds results:

LightHouse Reporting
1549546229.report.html

--automated message

SiAdcock
SiAdcock approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@SiAdcock SiAdcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes more sense anyway! ✨

nicl
nicl approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@nicl nicl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad that with hooks there is no longer an easy way to clearly describe stateless components by interface alone.

But agree this is a necessary change as we will obviously update the React version at some point.

@gtrufitt gtrufitt merged commit c5e2a2e into master Feb 11, 2019
@gtrufitt gtrufitt deleted the Tidy-rename-SFC branch July 26, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicl nicl nicl approved these changes

@AWare AWare AWare approved these changes

@SiAdcock SiAdcock SiAdcock approved these changes

@GHaberis GHaberis Awaiting requested review from GHaberis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gtrufitt @PRBuilds @nicl @AWare @SiAdcock