-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add validation errors to form fields for callouts" #6746
Conversation
Size Change: -13.7 kB (-1%) Total Size: 2.39 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
…-6722-tom-king-form-fields-refactor
…722-tom-king-form-fields-refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Reverts #6722
It looks like this change may have broken submission of our callout embed, perhaps due to a change in the model from frontend. As the weekend is approaching, it'd be best to revert this for now. Thankfully, this old callout embed has not been used for a while but it is still on some old articles.