-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Add validation errors to form fields for callouts"" #6752
Revert "Revert "Add validation errors to form fields for callouts"" #6752
Conversation
Size Change: -10.3 kB (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PRLighthouse tested 2 URLs Report for Article
Report for Front
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit puzzled by why there are Chromatic changes for apps-rendering
here, but I'm guessing it's a bug in CI, rather than something to do with this PR specifically?
Yes that is weird - said there was a change, even though they seemed identical? Also I hadn't touched anything in the AR part of the codebase. |
I thought a PR I merged had broken old callout embeds, but it hadn't - the form was just expired in Formstack. This puts the original PR back in.
Tagging @bryophyta who had originally approved the PR #6722
Reverts #6746