Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add caption to slideshow asset #264

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Add caption to slideshow asset #264

merged 2 commits into from
Mar 17, 2022

Conversation

jonathonherbert
Copy link
Contributor

What does this change?

Adds a caption property to the slideshow asset.

How to test

  • The automated tests should pass, showing we're happy that this field is optional, and we're backwards compatible with our current data

How can we measure success?

We should be able to add captions in our tooling, and pass them through to platforms.

@jonathonherbert jonathonherbert merged commit 6becff0 into master Mar 17, 2022
@jonathonherbert jonathonherbert deleted the jsh/add-caption-to-slideshow-asset branch March 17, 2022 18:02
@Fweddi Fweddi mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverlloyd oliverlloyd oliverlloyd approved these changes

@Fweddi Fweddi Fweddi approved these changes

@alinaboghiu alinaboghiu Awaiting requested review from alinaboghiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonathonherbert @oliverlloyd @Fweddi