Add SpecialReportAlt to CardStyle
#280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
TODO: This is the SNAPSHOT version for local testing. We will use the non-SNAPSHOT when it is published
ioannakok
changed the title
SpecialReportAlt to CardStyle
This was referenced Nov 2, 2022
ioannakok
reviewed
Nov 4, 2022
project/dependencies.scala
Outdated
| @@ -1,7 +1,7 @@ | |||
| import sbt._ | |||
|
|
|||
| object Dependencies { | |||
| val capiVersion = "19.0.3" | |||
| val capiVersion = "19.0.5-SNAPSHOT" | |||
There was a problem hiding this comment.
Will update with the right version after this gets merged: guardian/content-api-scala-client#371 and make build happy
davidfurey
approved these changes
Nov 4, 2022
This reverts commit 0b45ce0. Will push this after the release
Merged
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
SpecialReportAlttoCardstyle. We need this in order to be able to style the SpecialReportAlt cards in fronts rendered byfrontendas it relies onCardStyleto decide the class of the card.This PR is the 2nd in this series:
content-api-scala-client: Adds SpecialReportAltTheme and SpecialReportAlt hashed tag to content-api-scala-client: AddSpecialReportAltThemetoFormatcontent-api-scala-client#371facia-scala-client: Adds SpecialReportAlt to CardStyle: AddSpecialReportAlttoCardStyle#280 (current)frontend: Consumes the new clients and adds card styles for fronts rendered by frontend: Add SpecialReportAlt card styles frontend#25602How to test
Tested in frontend locally using the SNAPSHOT version.
Deployment