Implement and update tests

client-v2/src/actions/Collections.ts

@@ -1,7 +1,6 @@
 import { batchActions } from 'redux-batched-actions';
 import {
   getArticlesBatched,
-  updateCollection as updateCollectionFromApi,
   discardDraftChangesToCollection as discardDraftChangesToCollectionApi,
   fetchVisibleArticles,
   fetchLastPressed as fetchLastPressedApi,
@@ -71,6 +70,7 @@ import { State } from 'types/State';
 import { events } from 'services/GA';
 import { collectionParamsSelector } from 'selectors/collectionSelectors';
 import { fetchCollectionsStrategy } from 'strategies/fetch-collection';
+import { updateCollectionStrategy } from 'strategies/update-collection';
 
 const articlesInCollection = createAllArticlesInCollectionSelector();
 const collectionsInOpenFrontsSelector = createCollectionsInOpenFrontsSelector();
@@ -262,7 +262,11 @@ function updateCollection(collection: Collection): ThunkResult<Promise<void>> {
         getState(),
         collection.id
       );
-      await updateCollectionFromApi(collection.id, denormalisedCollection);
+      await updateCollectionStrategy(
+        getState(),
+        collection.id,
+        denormalisedCollection
+      );
       dispatch(collectionActions.updateSuccess(collection.id));
       const visibleArticles = await getVisibleArticles(
         collection,

client-v2/src/actions/__tests__/Persistence.spec.ts

@@ -39,6 +39,7 @@ const A4 = {
 
 const init = () => {
   const initState = {
+    path: '/v2/editorial',
     shared: {
       collections: {
         loadingIds: [],

client-v2/src/routes/editions.ts

@@ -0,0 +1,7 @@
+const api = (path: string) => `/editions-api/${path}`;
+
+const collection = (collectionId: string) => api(`collections/${collectionId}`);
+const editionIssue = (editionName: string, issueId: string) =>
+  api(`editions/${editionName}/issues/${issueId}`);
+
+export { collection, editionIssue };

client-v2/src/services/__tests__/faciaApi.spec.ts

@@ -63,15 +63,15 @@ describe('faciaApi', () => {
           })
       });
       expect.assertions(1);
-      return expect(updateCollection('exampleId', collection)).resolves.toEqual(
+      return expect(updateCollection('exampleId')(collection)).resolves.toEqual(
         collection
       );
     });
     it('should reject if the server gives a !2XX response', async () => {
       fetchMock.once('/v2Edits', { status: 400 });
       expect.assertions(1);
       try {
-        await updateCollection('exampleId', collection);
+        await updateCollection('exampleId')(collection);
       } catch (e) {
         expect(e.message).toContain('exampleId');
       }

client-v2/src/shared/fixtures/shared.ts

@@ -547,6 +547,7 @@ const collectionWithSupportingArticles = {
 };
 
 const stateWithCollection: any = {
+  path: '/v2/editorial',
   fronts: {
     frontsConfig: {
       data: {
@@ -651,6 +652,7 @@ const stateWithCollection: any = {
 };
 
 const stateWithCollectionAndSupporting: any = {
+  path: '/v2/editorial',
   shared: {
     collections: {
       data: {
@@ -712,6 +714,7 @@ const stateWithCollectionAndSupporting: any = {
 };
 
 const stateWithSnaplinksAndArticles: any = {
+  path: '/v2/editorial',
   shared: {
     articleFragments: {
       '1269c42e-a341-4464-b206-a5731b92fa46': {

client-v2/src/strategies/update-collection.ts

@@ -16,7 +16,7 @@ const collectionToEditionCollection = (
   };
 };
 
-const fetchCollectionsStrategy = (
+const updateCollectionStrategy = (
   state: State,
   id: string,
   collection: CollectionWithNestedArticles
@@ -28,4 +28,4 @@ const fetchCollectionsStrategy = (
     none: () => null
   });
 
-export { fetchCollectionsStrategy };
+export { updateCollectionStrategy };