Remove redundant check for open forms #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathonherbert
force-pushed
the
jsh/remove-redundant-check
branch
from
d9a47da
to
8619093
Compare
jonathonherbert
force-pushed
the
jsh/remove-redundant-check
branch
from
8619093
to
e51fcc6
Compare
jennygrahamjones
approved these changes
Oct 1, 2019
|
Seen on PROD (merged by @jonathonherbert 9 minutes and 44 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
We check to see if any forms are open when we render a collection. Since we moved forms to their inline state, we no longer need this check. This PR removes it.
Checklist
General
Client