Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overview label #766

Merged
merged 1 commit into from Jun 4, 2019
Merged

Fix overview label #766

merged 1 commit into from Jun 4, 2019

Conversation

jonathonherbert
Copy link
Contributor

What's changed?

The label htmlFor and toggle id for the overview toggle doesn't contain a front id. This means that with multiple fronts, toggling anything but the first overview via the label will toggle the first overview. 🤦‍♀ My mistake!

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

RichieAHB
RichieAHB approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@RichieAHB RichieAHB left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonathonherbert jonathonherbert merged commit 225b6a3 into master Jun 4, 2019
@jonathonherbert jonathonherbert deleted the jsh/fix-overview-label branch June 4, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichieAHB RichieAHB RichieAHB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonathonherbert @RichieAHB