Keep the overview open when the article form closes #770
Conversation
|
So does the overview actually stay visible here too? My assumption here was that we'd want to hide the overview while the panel was open but it reappears when cancel was clicked (or more generally, that the editor is closed). Mariana did mention the cancel button in the email ... you may already have discussed this and now that I think about it, this solution is probably better. I just wondered whether this is definitely the required behaviour? |
|
@RichieAHB -- no, the overview is hidden by the form when the form is present -- it's basically the old behaviour. |
| @@ -73,7 +73,8 @@ const FormContainer = styled(ContentContainer.withComponent('form'))` | |||
| min-width: ${formMinWidth}px; | |||
| max-width: 380px; | |||
| margin-left: 10px; | |||
| height: 100%; | |||
| margin-top: 10px; | |||
There was a problem hiding this comment.
A sneaky spacing edit to stop the form abutting the fronts header.
|
@jonathonherbert - I get it now. I thought the closing of the overview was the only thing stopping the overview rendering but I see here that there is already a check to ensure we don't render the overview if we have a form open 👍 |
|
@RichieAHB -- ah, yes, I could have made that clearer! |
What's changed?
A side effect of #749 (that I added) changed the behaviour of the form toggles -- opening a form would close the overview for the front. This isn't desirable re: feedback from Mariana, so this PR reverts that behaviour: opening a form doesn't interfere with the overview state.
Checklist
General
Client