Play 2.5 take 2 + csrf fixes #15367
Merged
Play 2.5 take 2 + csrf fixes #15367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 072cb7f.
We were checking csrf token instead of setting it and vice versa
jfsoul
approved these changes
Dec 16, 2016
|
|
||
| def wsClient: WSClient |
There was a problem hiding this comment.
Lets make this implicit and remove the "implicit val ws = wsClient" in loginAction and overrideRedirectUrl
| @@ -16,7 +16,7 @@ import scala.concurrent.Future | |||
| with ScalaFutures | |||
| with ConfiguredTestSuite | |||
| with BeforeAndAfterAll | |||
| with WithTestWsClient { | |||
| with WithMaterializer with WithTestWsClient { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
The csrf related commit 3e7d00f is the only changed not yet reviewed
What is the value of this and can you measure success?
Play 2.5 🎉
@markjamesbutler @jfsoul @DiegoVazquezNanini