Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting back some css I hastily removed #16376

Merged
merged 1 commit into from
Apr 6, 2017
Merged

Conversation

NataliaLKB
Copy link
Contributor

What does this change?

Sorry! I broke the footer in this commit: a3a73d1

What is the value of this and can you measure success?

Makes the footer look like its supposed to again

Does this affect other platforms - Amp, Apps, etc?

Nope

Screenshots

Before:
image

After:
image

Tested in CODE?

Nope

@PRBuilds
Copy link

PRBuilds commented Apr 6, 2017

PR build results:

screenshots
mobile.pngwide.pngtablet.pngdesktop.png

exceptions (0)
thrown-exceptions.js

webpagetest (2)
performanceComparisonSummary.txt

-automated message

Copy link
Contributor

@gu-stav gu-stav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@zeftilldeath zeftilldeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌴

@NataliaLKB NataliaLKB merged commit 271434e into master Apr 6, 2017
@NataliaLKB NataliaLKB deleted the nb-putting-back-css branch April 6, 2017 16:09
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @NataliaLKB 17 minutes and 26 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants