Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app logo in banner #21642

Merged
merged 6 commits into from
Jul 17, 2019
Merged

Update app logo in banner #21642

merged 6 commits into from
Jul 17, 2019

Conversation

webb04
Copy link
Contributor

@webb04 webb04 commented Jul 12, 2019

Updates the app logo and link to the play store.
To recreate:

  1. Incognito window on Android
  2. Clear cookie banner
  3. Visit Opinion or another pillar

What does this change?

Screenshots

Sorry for the photos, you can't screenshot incognito chrome now.

Before Android After Android

iOS is already ok:

What is the value of this and can you measure success?

Checklist

Does this affect other platforms?

  • AMP
  • Apps
  • Other (please specify)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

  • No
  • Yes (please give details)

Does this change break ad-free?

  • No
  • It did, but tests caught it and I fixed it
  • It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

Accessibility test checklist

Tested

  • Locally
  • On CODE (optional)

@PRBuilds
Copy link

PRBuilds commented Jul 12, 2019

PRbuilds results:

Screenshots
wide.pngdesktop.pngtablet.pngmobile.png

💚 A11y validation
a11y-report.txt

💚 Microdata Validation
microdata.txt

Apache Benchmark Load Testing
loadtesting.txt

LightHouse Reporting

--automated message

@webb04
Copy link
Contributor Author

webb04 commented Jul 15, 2019

@GHaberis I think we were too tired on Friday, do you know how to upload to https://assets.guim.co.uk/images/apps/?

@GHaberis
Copy link
Contributor

https://assets.guim.co.uk/images

Hah yep! OK I thought static assets added to https://github.com/guardian/frontend/tree/master/static are published to the https://assets.guim.co.uk domain, but https://assets.guim.co.uk/images/apps/ios-logo.png isn't in this repository so it must've been uploaded some other way. Perhaps someone @guardian/dotcom-platform might have a better idea?

@gtrufitt
Copy link
Contributor

Spoke to @philmcmahon - it's probably uploaded directly to S3 bucket that backs asset.guim - feel free to upload to the bucket (ping me for the name) or come over and we upload the new one!

Copy link
Contributor

@gtrufitt gtrufitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bar linting 👍

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @webb04 20 minutes and 56 seconds ago)

@ripecosta ripecosta deleted the jw-app-banner-logo branch November 12, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants