-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app logo in banner #21642
Update app logo in banner #21642
Conversation
PRbuilds results: Screenshots 💚 A11y validation 💚 Microdata Validation Apache Benchmark Load Testing LightHouse Reporting --automated message |
@GHaberis I think we were too tired on Friday, do you know how to upload to |
Hah yep! OK I thought static assets added to https://github.com/guardian/frontend/tree/master/static are published to the https://assets.guim.co.uk domain, but https://assets.guim.co.uk/images/apps/ios-logo.png isn't in this repository so it must've been uploaded some other way. Perhaps someone @guardian/dotcom-platform might have a better idea? |
Spoke to @philmcmahon - it's probably uploaded directly to S3 bucket that backs asset.guim - feel free to upload to the bucket (ping me for the name) or come over and we upload the new one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bar linting
👍
Seen on PROD (merged by @webb04 20 minutes and 56 seconds ago)
|
Updates the app logo and link to the play store.
To recreate:
What does this change?
Screenshots
Sorry for the photos, you can't screenshot incognito chrome now.
iOS is already ok:
What is the value of this and can you measure success?
Checklist
Does this affect other platforms?
Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?
Does this change break ad-free?
Does this change update the version of CAPI we're using?
Accessibility test checklist
Tested