Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team id to json response for DCR #22652

Merged
merged 2 commits into from
Jun 13, 2020
Merged

Add team id to json response for DCR #22652

merged 2 commits into from
Jun 13, 2020

Conversation

oliverlloyd
Copy link
Contributor

@oliverlloyd oliverlloyd commented Jun 8, 2020

What does this change?

Adds the id property to the team object returned to DCR for match stats

Before

Screenshot 2020-06-08 at 17 39 11

After

Screenshot 2020-06-08 at 17 38 00

@oliverlloyd oliverlloyd marked this pull request as ready for review June 8, 2020 16:46
@oliverlloyd oliverlloyd requested a review from shtukas June 8, 2020 16:46
@shtukas
Copy link
Contributor

shtukas commented Jun 9, 2020

@oliverlloyd I have just noticed this. Sorry I didn't see it before. It's conflicting with master. Let me fix that and then I will merge.

@shtukas
Copy link
Contributor

shtukas commented Jun 9, 2020

After merging from master:

Screenshot 2020-06-09 at 16 51 36

@shtukas shtukas merged commit 0ae8a31 into master Jun 13, 2020
@shtukas shtukas deleted the oliver/team-id-for-match branch June 13, 2020 15:26
@prout-bot
Copy link
Collaborator

Seen on PROD (created by @oliverlloyd and merged by @shtukas 16 minutes and 36 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants