Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fronts banner adverts #26151

Merged
merged 1 commit into from
May 25, 2023
Merged

Fronts banner adverts #26151

merged 1 commit into from
May 25, 2023

Conversation

domlander
Copy link
Contributor

@domlander domlander commented May 17, 2023

What does this change?

Updates references to commercial so that we can serve fronts-banner ads on the UK Network Front behind an AB test.

Commercial PRs:

Does this change need to be reproduced in dotcom-rendering ?

  • No
  • Yes (please indicate your plans for DCR Implementation)

At this time, we plan to run an AB test against Frontend so that we can assess the commercial impact of serving fronts-banner ads. Later, assuming the AB test returns positive results, we will look to implement in DCR.

Screenshots

image

What is the value of this and can you measure success?

So that we can run an AB test to assess the commercial impact of a new ad strategy on fronts pages. This involves banner ads between sections instead of merchandise slots and MPUs.

Testing

This has been tested locally and on CODE

@domlander domlander force-pushed the doml/fronts-banner-ads-on-frontend branch 6 times, most recently from b0f3059 to 372268d Compare May 24, 2023 15:32
@domlander domlander force-pushed the doml/fronts-banner-ads-on-frontend branch from 372268d to e293b89 Compare May 24, 2023 16:32
@domlander domlander marked this pull request as ready for review May 24, 2023 16:42
@domlander domlander requested a review from a team as a code owner May 24, 2023 16:42
@Jakeii Jakeii merged commit 2bb4246 into main May 25, 2023
2 checks passed
@Jakeii Jakeii deleted the doml/fronts-banner-ads-on-frontend branch May 25, 2023 14:14
@prout-bot
Copy link
Collaborator

Seen on FRONTS-PROD, ADMIN-PROD (created by @domlander and merged by @Jakeii 20 minutes and 41 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants