-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fronts-banner ads to Frontend UK Network Front #877
Conversation
🚀 @guardian/commercial-bundle-v5.0.1-beta.6 published to npm as a beta release |
c487303
to
7e7ad3b
Compare
🚀 @guardian/commercial-bundle-v5.0.1-beta.7 published to npm as a beta release |
9b1a673
to
d094bc5
Compare
🚀 @guardian/commercial-bundle-v5.1.1-beta.0 published to npm as a beta release |
d094bc5
to
480e7f9
Compare
🚀 @guardian/commercial-bundle-v5.2.1-beta.0 published to npm as a beta release |
480e7f9
to
b581906
Compare
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!🚀 Just a few suggestions
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
🚀 @guardian/commercial-bundle-v5.2.1-beta.1 published to npm as a beta release |
🎉 This PR is included in version @guardian/commercial-bundle-v5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this change?
Add fronts-banner ads to Frontend UK Network Front.
Ads will be inserted above the following sections:
opinion
,sport
,around-the-world
,lifestyle
,in-pictures
.This functionality is behind an AB test which looks to test a new ad strategy on Fronts pages. For this test, the new adverts will only be inserted in the following conditions:
Why?
So that we can gather results for an AB test regarding the commercial impact of a new ad strategy.
Screenshots