feat: Add fronts-banner ads to Frontend UK Network Front #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 @guardian/commercial-bundle-v5.0.1-beta.6 published to npm as a beta release |
domlander
force-pushed
the
doml/fronts-banner-ads-on-frontend
branch
from
c487303
to
7e7ad3b
Compare
|
🚀 @guardian/commercial-bundle-v5.0.1-beta.7 published to npm as a beta release |
domlander
force-pushed
the
doml/fronts-banner-ads-on-frontend
branch
from
9b1a673
to
d094bc5
Compare
domlander
added
[beta] @guardian/commercial-bundle
and removed
[beta] @guardian/commercial-bundle
labels
|
🚀 @guardian/commercial-bundle-v5.1.1-beta.0 published to npm as a beta release |
domlander
force-pushed
the
doml/fronts-banner-ads-on-frontend
branch
from
d094bc5
to
480e7f9
Compare
domlander
added
[beta] @guardian/commercial-bundle
and removed
[beta] @guardian/commercial-bundle
labels
|
🚀 @guardian/commercial-bundle-v5.2.1-beta.0 published to npm as a beta release |
domlander
force-pushed
the
doml/fronts-banner-ads-on-frontend
branch
from
480e7f9
to
b581906
Compare
arelra
reviewed
May 24, 2023
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
Jakeii
reviewed
May 24, 2023
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
Jakeii
reviewed
May 24, 2023
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
Jakeii
approved these changes
May 24, 2023
Jakeii
reviewed
May 24, 2023
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
arelra
reviewed
May 24, 2023
bundle/src/projects/commercial/modules/fronts-banner-adverts.ts
Outdated
Show resolved
Hide resolved
arelra
approved these changes
May 24, 2023
domlander
added
[beta] @guardian/commercial-bundle
and removed
[beta] @guardian/commercial-bundle
labels
|
🚀 @guardian/commercial-bundle-v5.2.1-beta.1 published to npm as a beta release |
|
🎉 This PR is included in version @guardian/commercial-bundle-v5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Add fronts-banner ads to Frontend UK Network Front.
Ads will be inserted above the following sections:
opinion,sport,around-the-world,lifestyle,in-pictures.This functionality is behind an AB test which looks to test a new ad strategy on Fronts pages. For this test, the new adverts will only be inserted in the following conditions:
Why?
So that we can gather results for an AB test regarding the commercial impact of a new ad strategy.
Screenshots