-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show ads on mobile discussion #26899
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2024
fa32e3d
to
7b37c10
Compare
9e56be0
to
a6d4de5
Compare
mxdvl
approved these changes
Feb 22, 2024
domlander
approved these changes
Feb 22, 2024
Seen on FRONTS-PROD, ADMIN-PROD (merged by @deedeeh 13 minutes and 4 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
Ads will be added to the comments section in DCR articles on mobile devices. This should provide an increase in revenue for mobile pageviews. This feature has been added behind a switch, so that we can turn it off if needed.
What does this change?
This PR is part of Commercial OKR work. Check these PRs for more information guardian/commercial#1239 and guardian/dotcom-rendering#10448