Show ads on mobile discussion #10448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.01 kB (0%) Total Size: 763 kB
ℹ️ View Unchanged
|
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
from
708d6f7
to
3963649
Compare
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
2 times, most recently
from
0bf24b9
to
189ad25
Compare
This was referenced Feb 13, 2024
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
from
27c337b
to
bd1bb9c
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the |
domlander
reviewed
Feb 14, 2024
domlander
reviewed
Feb 14, 2024
mxdvl
reviewed
Feb 15, 2024
dotcom-rendering/src/experiments/tests/mobile-discussion-ads.ts
Outdated
Show resolved
Hide resolved
dotcom-rendering/src/experiments/tests/mobile-discussion-ads.ts
Outdated
Show resolved
Hide resolved
I believe we're planning to reuse this logic to make a similar change in frontend. From a maintainability perspective, it makes sense to me to keep this reusable logic in commercial, instead of having it defined one way in DCR, and then in a different way for frontend. |
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
from
d23bde6
to
423508f
Compare
mxdvl
reviewed
Feb 16, 2024
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
2 times, most recently
from
db309c2
to
3d20ee0
Compare
abeddow91
approved these changes
Feb 20, 2024
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
from
2d04bdc
to
5ef5932
Compare
emma-imber
changed the title
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
from
c6fc227
to
b0ff7fa
Compare
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
Co-authored-by: Dominik Lander <dominik.lander@guardian.co.uk>
Co-authored-by: Max Duval <max.duval@theguardian.com>
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
Co-authored-by: Emma Imber <108270776+emma-imber@users.noreply.github.com>
emma-imber
force-pushed
the
dina/show-ads-on-mobile-discussion
branch
from
b0ff7fa
to
45dc6b8
Compare
mxdvl
reviewed
Feb 21, 2024
| } | ||
| }, [isWeb, expanded, loading, enableMobileDiscussionAdsSwitch]); | ||
|
|
||
| const commentsStateChangeEvent = new CustomEvent('comments-state-change'); |
There was a problem hiding this comment.
Does this need to be defined within the component’s body?
There was a problem hiding this comment.
We should add a test for DiscussionWeb in Island.test.tsx
mxdvl
approved these changes
Feb 21, 2024
|
How long is the |
Yes we don't need it long-term, a week or so, just to give us the ability to switch it off quickly if we need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR is part of Commercial OKR work. We're inserting MPU ads in mobile discussion behind a switch. Other PRs linked to this one guardian/commercial#1239 and guardian/frontend#26899
The first ad is shown after the 4th comment and then an ad is inserted after every 5 comments. We don't insert every 5 comments from the beginning because the number of comments is usually a multiple of 5, and showing an ad after the last comment doesn't look right from a UX point of view.
When the comments are expanded and are finished loading we dispatch a custom event
comments-loadedto Commercial. The Commercial code handles this event and inserts ads.When the user makes any changes to the filter or change the comments page number we dispatch the
comments-state-changeevent which removes the previous ad slots.Comments in apps will be served via DCR, which is a work in progress in WebX, so we added a check to insert ads if we are only in Web.
Why?
Increase revenue and ad ratio without impacting the user experience.
Demo
mobile-expanded-comments-480.mov