Service changes for Leases in ES #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenoir
changed the title
| def put(lease: MediaLease) = Scanamo.put(client)(tableName)(lease.copy(id=uuid)) | ||
| def delete(id: String) = Scanamo.delete(client)(tableName)(key(id)) | ||
| def put(lease: MediaLease) = Future { Scanamo.put[MediaLease](client)(tableName)(lease.copy(id=uuid)) } | ||
| def delete(id: String) = Future { Scanamo.delete(client)(tableName)(key(id)) } |
There was a problem hiding this comment.
I added these so I could use the results as promises (i.e. chain subsequent actions), is this the right way to do it?
I noticed the other methods in here returned mappable objects but these didn't so I wasn't sure.
There was a problem hiding this comment.
I think Scanamo now supports async requests, but this is ok for now.
|
I think some of the optimised stuff is getting overridden here. Otherwise I just asked had a few conceptual comments, no blockers |
kenoir
force-pushed
the
leases-es-backend
branch
from
6349cc0
to
d2698f4
Compare
kenoir
force-pushed
the
leases-es-backend
branch
from
d2698f4
to
abab74f
Compare
kenoir
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.