Restrict download of images to users with edit_metadata permisssion where that user is not the image uploader #3873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the addition of new restrictDownload parameter. Limiting downloads to the same conditions as can_crop. Where restrictDownload enabled, download will not be available for images where valid evaluate to false. Where multiple images are selected and some are available but other are not, this is highlighted in the UI through a warning icon and tooltip.
Added css to style position of download warning icon Added userCanEdit property to image response which is mapped to the userCanEdit permission. This value is used to determine the set of downloadable images. Co-authored-by: Ara Cho <ara.cho@guardian.co.uk>
phillipbarron
force-pushed
the
restrict-download-of-non-uploader-to-edit-metadata-permission
branch
from
9b54280
to
e16df7b
Compare
Remove redundant var from controller Using button for download rather than link for consistency
phillipbarron
changed the title
Added 1 GB memory limit to EElastic Docker compose to address instability Updated tooltip to refer to one or many images
Removed redundant or condition for rendering low-res download button
phillipbarron
commented
Oct 3, 2022
|
|
||
| // const isTooBig = blob.size > maxBlobSize; | ||
| const isTooBig = false; | ||
| // const isTooBig = blob.size > maxBlobSize; |
There was a problem hiding this comment.
Can we remove this?
…n-downloadable images are selected
phillipbarron
commented
Oct 4, 2022
andrew-nowak
reviewed
Oct 4, 2022
aracho1
approved these changes
Oct 5, 2022
phillipbarron
deleted the
restrict-download-of-non-uploader-to-edit-metadata-permission
branch
|
Seen on cropper, collections, image-loader, metadata-editor, thrall, leases (merged by @phillipbarron 15 minutes and 31 seconds ago) Please check your changes! |
|
Seen on usage, kahuna, media-api, auth (merged by @phillipbarron 16 minutes and 21 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Download of images is restricted to users who have the
edit_metadatapermission. This is passed to the client in the image_response object to allow filtering.Where a mix of downloadable and non-downloadable images are selected, a warning icon and accompanying tooltip indicate that a limited set of the selected imaged are downloadable. Those images with no user permission are filtered from the resulting zip archive.
Config is now passed as an object rather that individual config items.
ES_JAVA_OPTSlimiting memory usage to 1GB have been added to the docker environment configuration for Elastic search to address instability with the container during dev.How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?