This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Membership content 404 #1497
Merged
Membership content 404 #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 10, 2017 11:54
…that way we can for-yield over them and set a default behaviour.
… the cases where the query params are Empty.
rtyley
suggested changes
Feb 10, 2017
| @@ -80,7 +80,7 @@ object Joiner extends Controller with ActivityTracking | |||
| contentURL <- contentRefererOpt if Uri.parse(contentURL).host.contains("www.theguardian.com") | |||
| access <- accessOpt | |||
| } yield { | |||
| Redirect(routes.MemberOnlyContent.membershipContent(contentURL, access.name)) | |||
| Redirect(routes.MemberOnlyContent.membershipContent(Some(contentURL))) | |||
There was a problem hiding this comment.
Probably legacy code at this point - is anyone still directing users to /tier-chooser as a content-access handler?
| } | ||
| }).getOrElse( | ||
| Redirect(routes.Joiner.tierChooser()) | ||
| Future(Redirect(("https://membership.theguardian.com/supporter"))) |
There was a problem hiding this comment.
Use the reverse-routing handler!
| Ok(views.html.joiner.membershipContent(pageInfo, accessOpt, signInUrl, capiContent, s"Exclusive Members Content: $headline")). | ||
| withSession(request.session + (DestinationService.JoinReferrer -> ("https://" + Config.guardianHost +"/" + referringContent))) | ||
| } else { | ||
| Redirect(("https://theguardian.com/" + referringContent)) | ||
| } | ||
| }).getOrElse( |
There was a problem hiding this comment.
Is it worth considering fold? https://kwangyulseo.com/2014/05/21/scala-option-fold-vs-option-mapgetorelse/
rtyley
reviewed
Feb 10, 2017
| import model._ | ||
| import play.api.libs.concurrent.Execution.Implicits.defaultContext | ||
| import play.api.mvc._ | ||
| import services.{GuardianContentService, _} | ||
| import views.support.PageInfo | ||
|
|
||
| import scala.concurrent.Future |
There was a problem hiding this comment.
I am using Future in line 26
rtyley
approved these changes
Feb 10, 2017
|
It is working on PROD. |
|
✅ Testing in PROD passed! Details |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
There are several errors in Sentry (here) about requests to /membership-content which are returning 400 Bad Request. The main reason for this is because the request doesn't have the necessary query parameters. At the same time, we spotted that are crawlers that are driven traffic to /membership-content also without the required parameters.
Therefore, in this PR we are deleting one of the parameters and marking the other one as optional and if we don't receive it, we direct that traffic to the supporter landing page.
Trello card: Here and Here
Changes
Screenshots
/membership-content
/membership-content?referringContent=membership/audio/2017/feb/02/we-need-to-talk-about-climate-change-guardian-members-exclusive-podcast
/membership-content?referringContent=membership/audio/2017/feb/02/we-need-to-talk-about-climate-change-guardian-members-exclusive-podcast&membershipAccess=MembersOnly