Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-4704: Add ec2 worker sender queue url parameter #805

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

frankie297
Copy link
Contributor

What does this change?

Adds a new parameter to store the EC2 Workers SQS Queues URLs. This is so we can use the parameter to retrieve messages from the SQS queues. We know the parameter already exists for the harvester, the neatest way is to duplicate that parameter and modify the name for the ec2 worker namespace.

How to test

Deploy to CODE and see if the parameter is generated

Copy link
Contributor

@DavidLawes DavidLawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deployed to CODE and we could see the corresponding ssm parameters had been successfully created.

Given the parameters now exist we can reference the queue urls in the ec2worker config, which is needed when polling for sqs messages

Copy link
Contributor

@waisingyiu waisingyiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like a good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants